Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: new reloadable config in jobsdb #3868

Merged
merged 1 commit into from
Sep 15, 2023
Merged

chore: new reloadable config in jobsdb #3868

merged 1 commit into from
Sep 15, 2023

Conversation

Sidddddarth
Copy link
Member

@Sidddddarth Sidddddarth commented Sep 14, 2023

Description

Use new reloadable config in jobsdb.

Linear Ticket

new reloadable config in jobsdb

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@Sidddddarth Sidddddarth changed the base branch from master to feature/pipe-257-update-rudderserver-to-remove-deprecated-config-calls September 14, 2023 14:11
Base automatically changed from feature/pipe-257-update-rudderserver-to-remove-deprecated-config-calls to master September 14, 2023 14:12
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage: 94.25% and project coverage change: +0.08% 🎉

Comparison is base (12f4d83) 68.81% compared to head (68ca5c6) 68.90%.

❗ Current head 68ca5c6 differs from pull request most recent head 296f098. Consider uploading reports for the commit 296f098 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3868      +/-   ##
==========================================
+ Coverage   68.81%   68.90%   +0.08%     
==========================================
  Files         351      351              
  Lines       52746    52746              
==========================================
+ Hits        36299    36345      +46     
+ Misses      14130    14088      -42     
+ Partials     2317     2313       -4     
Files Changed Coverage Δ
jobsdb/migration.go 71.12% <72.72%> (+1.27%) ⬆️
jobsdb/backup.go 69.25% <85.71%> (+3.37%) ⬆️
jobsdb/jobsdb.go 71.33% <98.55%> (+0.48%) ⬆️

... and 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sidddddarth Sidddddarth merged commit 2c655f9 into master Sep 15, 2023
33 checks passed
@Sidddddarth Sidddddarth deleted the chore.jobsdb branch September 15, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants