chore(batchrouter): honour upload frequency when limitsReached if destination is failing #3874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atzoum
commented
Sep 15, 2023
router/batchrouter/handle.go
Outdated
| @@ -245,7 +248,8 @@ func (brt *Handle) getWorkerJobs(partition string) (workerJobs []*DestinationJob | |||
| if batchDest, ok := destinationsMap[destID]; ok { | |||
| var processJobs bool | |||
| brt.lastExecTimesMu.Lock() | |||
| if limitsReached && !brt.forceHonorUploadFrequency { // if limits are reached, process all jobs regardless of their upload frequency | |||
There was a problem hiding this comment.
**Note: ** forceHonorUploadFrequency is being removed in #3871
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3874 +/- ##
==========================================
+ Coverage 68.81% 68.84% +0.03%
==========================================
Files 351 351
Lines 52746 52752 +6
==========================================
+ Hits 36299 36319 +20
+ Misses 14130 14112 -18
- Partials 2317 2321 +4
☔ View full report in Codecov by Sentry. |
lvrach
approved these changes
Sep 15, 2023
atzoum
requested review from
Sidddddarth,
cisse21,
BonapartePC,
achettyiitr and
fracasula
achettyiitr
reviewed
Sep 15, 2023
| @@ -116,6 +116,9 @@ type Handle struct { | |||
| lastExecTimesMu sync.RWMutex | |||
| lastExecTimes map[string]time.Time | |||
|
|
|||
| failingDestinationsMu sync.RWMutex | |||
| failingDestinations map[string]bool | |||
There was a problem hiding this comment.
Suggested change
| failingDestinations map[string]bool | |
| failingDestinations map[string]struct{} |
Is it possible to use empty structs here, since currently it is being used as set only?
There was a problem hiding this comment.
Then we would need to delete from the set when the destination starts succeeding. Both are equally valid solutions in my head. I went with the one that requires the less amount of lines :)
achettyiitr
approved these changes
Sep 15, 2023
…tination is failing
atzoum
force-pushed
the
chore.batchrtFailures
branch
from
e8e3a93
to
1a6bacb
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a destination is failing there is no point in keep retrying jobs continuously even if there are a lot of jobs in the queue (limitsReached in jobsdb query).
Linear Ticket
PIPE-283
Security