Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increasing default marketo bulk upload timeout #3940

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

shrouti1507
Copy link
Contributor

@shrouti1507 shrouti1507 commented Oct 4, 2023

Description

We are facing difficulties in uploading file with large volume data, for example 100K and that is why we are increasing the timeout for upload as 10 Minute

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@shrouti1507 shrouti1507 added the enhancement New feature or request label Oct 4, 2023
@shrouti1507 shrouti1507 self-assigned this Oct 4, 2023
@shrouti1507 shrouti1507 changed the title fix: increasing default marketo upload timeout fix: increasing default marketo bulk upload timeout Oct 4, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6da163b) 70.23% compared to head (5da183d) 70.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3940      +/-   ##
==========================================
- Coverage   70.23%   70.21%   -0.02%     
==========================================
  Files         357      357              
  Lines       53275    53275              
==========================================
- Hits        37417    37407      -10     
- Misses      13601    13608       +7     
- Partials     2257     2260       +3     
Files Coverage Δ
...onmanager/marketo-bulk-upload/marketobulkupload.go 0.00% <0.00%> (ø)

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shrouti1507 shrouti1507 merged commit bd9166b into master Oct 5, 2023
41 of 44 checks passed
@github-actions github-actions bot deleted the fix.marketo-file-upload-timeout branch December 5, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants