Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add autovacuum_vacuum_cost_limit to the reports table [PIPE-512] #4136

Merged
merged 14 commits into from
Nov 17, 2023

Conversation

BonapartePC
Copy link
Contributor

@BonapartePC BonapartePC commented Nov 14, 2023

Description

add autovacuum_vacuum_cost_limit to the reports table

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@BonapartePC BonapartePC changed the title fix: add autovacuum_vacuum_cost_limit to the system fix: add autovacuum_vacuum_cost_limit to the system [PIPE 512] Nov 14, 2023
@lvrach
Copy link
Member

lvrach commented Nov 14, 2023

we wanted to do this for report table right? Do we also see value for jobsdb ?

@BonapartePC BonapartePC changed the title fix: add autovacuum_vacuum_cost_limit to the system [PIPE 512] fix: add autovacuum_vacuum_cost_limit to the system [PIPE-512] Nov 14, 2023
@BonapartePC BonapartePC force-pushed the fix.autoVacuumCostLimit branch 2 times, most recently from a231c7c to 86c0584 Compare November 16, 2023 04:55
@BonapartePC BonapartePC changed the title fix: add autovacuum_vacuum_cost_limit to the system [PIPE-512] fix: add autovacuum_vacuum_cost_limit to the reports table [PIPE-512] Nov 16, 2023
@BonapartePC
Copy link
Contributor Author

we wanted to do this for report table right? Do we also see value for jobsdb ?

Made the changes to add for reports table

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (1621628) 72.37% compared to head (874c827) 72.33%.

Files Patch % Lines
enterprise/reporting/reporting.go 80.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4136      +/-   ##
==========================================
- Coverage   72.37%   72.33%   -0.04%     
==========================================
  Files         382      382              
  Lines       55420    55430      +10     
==========================================
- Hits        40109    40098      -11     
- Misses      12981    12995      +14     
- Partials     2330     2337       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BonapartePC BonapartePC merged commit 690aeb0 into master Nov 17, 2023
42 checks passed
@achettyiitr achettyiitr deleted the fix.autoVacuumCostLimit branch January 12, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants