chore: tune shared db connection pooling #4213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the TipsChat with CodeRabbit Bot (
|
atzoum
changed the title
BonapartePC
reviewed
Dec 7, 2023
atzoum
force-pushed
the
chore.tuneSharedDBConns
branch
from
5c08fac
to
2745564
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/v1.18.x #4213 +/- ##
===================================================
- Coverage 74.40% 72.66% -1.74%
===================================================
Files 397 387 -10
Lines 58330 56488 -1842
===================================================
- Hits 43399 41049 -2350
- Misses 12623 13068 +445
- Partials 2308 2371 +63 ☔ View full report in Codecov by Sentry. |
cisse21
approved these changes
Dec 7, 2023
Sidddddarth
reviewed
Dec 7, 2023
| @@ -192,5 +192,7 @@ func setupDBConn(conf *config.Config) (*sql.DB, error) { | |||
| if err := db.Ping(); err != nil { | |||
| return nil, fmt.Errorf("db ping: %v", err) | |||
| } | |||
| db.SetMaxIdleConns(conf.GetInt("drainConfig.maxIdleConns", 1)) | |||
| db.SetMaxOpenConns(conf.GetInt("drainConfig.maxOpenConns", 2)) | |||
There was a problem hiding this comment.
We could get away with db.SetMaxOpenConns(1) if we remove the two drainConfig routines from gatewayAppHandler.
As for processor, both routines can carry on with one connection imo.
Sidddddarth
reviewed
Dec 7, 2023
| @@ -202,6 +203,9 @@ func NewJobService(config JobServiceConfig) (JobService, error) { | |||
| if config.MaxPoolSize <= 2 { | |||
| config.MaxPoolSize = 2 // minimum 2 connections in the pool for proper startup | |||
| } | |||
| if config.MinPoolSize <= 0 { | |||
There was a problem hiding this comment.
why not an upper limit for both of them too..?
maxConns := lo.Clamp(config.MaxPoolSize, 2, 3)
minConss := lo.Clamp(config.MinPoolSize, 1, 2)
There was a problem hiding this comment.
I don't think we need to limit a configuration option that is there just for overriding it in case we face some issue in production
Sidddddarth
approved these changes
Dec 7, 2023
Merged
1 task
This was referenced Jan 8, 2024
This was referenced Jan 15, 2024
Merged
This was referenced Feb 9, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Trying to minimise each rudder-server's footprint on the overall number of shared postgres's connections
Security