Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle consent management configuration fallback for gcm #4355

Merged

Conversation

saikumarrs
Copy link
Member

Description

Instead of using event.context.consentManagement.provider as the differentiator b/w legacy and generic consent management, I've updated the logic prefer GCM config first, then fallback to legacy consents config.

This would ensure that the latest v3 JS SDK would be fully compatible with the server and enable us to switch our beta (GCM) users b/w legacy and generic consent management with the help of a feature flag in webapp.

Still, the users will have to set the consents data appropriately in the UI for either of the config fields.

Linear Ticket

https://linear.app/rudderstack/issue/SDK-998/make-legacy-consent-configuration-fields-source-specific

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@saikumarrs saikumarrs self-assigned this Jan 27, 2024
Copy link
Contributor

coderabbitai bot commented Jan 27, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

@bardisg bardisg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is to be merged only after GCM becomes available to all customers and destinations

@saikumarrs
Copy link
Member Author

I assume this is to be merged only after GCM becomes available to all customers and destinations

@bardisg , this would be needed for our phase 1 release as well, if our customers want to go back to using legacy consent management.

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e1789a5) 73.99% compared to head (8098b6a) 74.10%.
Report is 2 commits behind head on master.

❗ Current head 8098b6a differs from pull request most recent head 2f809bc. Consider uploading reports for the commit 2f809bc to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4355      +/-   ##
==========================================
+ Coverage   73.99%   74.10%   +0.10%     
==========================================
  Files         390      390              
  Lines       55275    55275              
==========================================
+ Hits        40903    40963      +60     
+ Misses      12044    11994      -50     
+ Partials     2328     2318      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saikumarrs saikumarrs merged commit 7e47ee9 into master Jan 31, 2024
40 checks passed
@Sidddddarth Sidddddarth deleted the fix.correctly-handle-consents-compatibility-sdk-998 branch January 31, 2024 09:17
This was referenced Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants