-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle consent management configuration fallback for gcm #4355
fix: handle consent management configuration fallback for gcm #4355
Conversation
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this is to be merged only after GCM becomes available to all customers and destinations
@bardisg , this would be needed for our phase 1 release as well, if our customers want to go back to using legacy consent management. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4355 +/- ##
==========================================
+ Coverage 73.99% 74.10% +0.10%
==========================================
Files 390 390
Lines 55275 55275
==========================================
+ Hits 40903 40963 +60
+ Misses 12044 11994 -50
+ Partials 2328 2318 -10 ☔ View full report in Codecov by Sentry. |
Description
Instead of using
event.context.consentManagement.provider
as the differentiator b/w legacy and generic consent management, I've updated the logic prefer GCM config first, then fallback to legacy consents config.This would ensure that the latest v3 JS SDK would be fully compatible with the server and enable us to switch our beta (GCM) users b/w legacy and generic consent management with the help of a feature flag in webapp.
Still, the users will have to set the consents data appropriately in the UI for either of the config fields.
Linear Ticket
https://linear.app/rudderstack/issue/SDK-998/make-legacy-consent-configuration-fields-source-specific
Security