-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: revert update error table with new columns and fix count issue #4380
Conversation
This reverts commit b8b5527.
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4380 +/- ##
==========================================
+ Coverage 75.51% 75.54% +0.02%
==========================================
Files 381 381
Lines 46093 46077 -16
==========================================
Hits 34807 34807
+ Misses 8998 8982 -16
Partials 2288 2288 ☔ View full report in Codecov by Sentry. |
- fix: count column in errors table
We have an active discussion on considering event_name with the aggregation logic and reverting these changes.
But we are not reverting the entire PR. We are including the fix related to the error count after aggregation.
Reverts #4356
Resolves INT-1574