Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always look for list item error for bingads audience #4430

Merged
merged 5 commits into from Feb 29, 2024

Conversation

shrouti1507
Copy link
Contributor

Description

we are encountering issue with bingAds bulk API returning client ID as empty string. This happening because we are just checking the row name with string "error", which will take custom list error as well that is not supposed to have a client id and will break with 500 error code.
For now we are checking specifically for list item error rows, where the client id presence is expected . Also added test case around that.
changes of :
#4429

Linear Ticket

Resolves INT-1682

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@shrouti1507 shrouti1507 added the bug Something isn't working label Feb 28, 2024
@shrouti1507 shrouti1507 self-assigned this Feb 28, 2024
Copy link
Contributor

coderabbitai bot commented Feb 28, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@cisse21 cisse21 merged commit 8462215 into release/1.20.x Feb 29, 2024
40 checks passed
@cisse21 cisse21 deleted the bingAds-list-error branch February 29, 2024 06:55
lvrach added a commit that referenced this pull request Mar 15, 2024
* fix: dontbatch-not-persisted

* chore: release 1.21.0

* fix: always look for list item error for bingads audience (#4430)

* chore: release 1.21.1 (#4478)

---------

Co-authored-by: Chandra shekar Varkala <chandra@rudderlabs.com>
Co-authored-by: devops-github-rudderstack <88187154+devops-github-rudderstack@users.noreply.github.com>
Co-authored-by: shrouti1507 <60211312+shrouti1507@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants