chore: addressed comments

rudderlabs · Feb 29, 2024 · 0582f0a · 0582f0a
1 parent a0493a0
commit 0582f0a
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/src/v0/util/index.js b/src/v0/util/index.js
@@ -2208,8 +2208,8 @@ const combineBatchRequestsWithSameJobIds = (inputBatches) => {
  * @returns {string} Event name converted to string.
  */
 const validateEventAndLowerCaseConversion = (event, isMandatory, convertToLowerCase) => {
-  if (typeof event === 'object' || !isDefined(event)) {
-    throw new InstrumentationError('Event should not be a object, function, NaN or undefined');
+  if (!isDefined(event) || typeof event === 'object' || typeof event === 'boolean') {
+    throw new InstrumentationError('Event should not be a object, NaN, boolean or undefined');
   }
 
   // handling 0 as it is a valid value

diff --git a/src/v0/util/index.test.js b/src/v0/util/index.test.js
@@ -496,4 +496,13 @@ describe('validateEventAndLowerCaseConversion Tests', () => {
       validateEventAndLowerCaseConversion(undefined, false, true);
     }).toThrow(InstrumentationError);
   });
+
+  it('should throw error for boolean values', () => {
+    expect(() => {
+      validateEventAndLowerCaseConversion(true, true, true);
+    }).toThrow(InstrumentationError);
+    expect(() => {
+      validateEventAndLowerCaseConversion(false, false, false);
+    }).toThrow(InstrumentationError);
+  });
 });