fix: do not send 298 event for aborted ones in ut

rudderlabs · Oct 19, 2023 · d414064 · d414064
1 parent 8261ab3
commit d414064
Show file tree

Hide file tree

Showing 4 changed files with 79 additions and 7 deletions.
diff --git a/src/services/userTransform.ts b/src/services/userTransform.ts
@@ -96,6 +96,12 @@ export default class UserTransformService {
 
           const transformedEventsWithMetadata: ProcessorTransformationResponse[] = [];
           destTransformedEvents.forEach((ev) => {
+            // add messageId to output set
+            if (ev.metadata?.messageId) {
+              messageIdsInOutputSet.add(ev.metadata.messageId);
+            } else if (ev.metadata?.messageIds) {
+              ev.metadata.messageIds.forEach((id) => messageIdsInOutputSet.add(id));
+            }
             if (ev.error) {
               transformedEventsWithMetadata.push({
                 statusCode: 400,
@@ -114,12 +120,6 @@ export default class UserTransformService {
               } as ProcessorTransformationResponse);
               return;
             }
-            // add messageId to output set
-            if (ev.metadata?.messageId) {
-              messageIdsInOutputSet.add(ev.metadata.messageId);
-            } else if (ev.metadata?.messageIds) {
-              ev.metadata.messageIds.forEach((id) => messageIdsInOutputSet.add(id));
-            }
             transformedEventsWithMetadata.push({
               output: ev.transformedEvent,
               metadata: isEmpty(ev.metadata) ? commonMetadata : ev.metadata,

diff --git a/test/__tests__/data/user_transformation_service_filter_input.json b/test/__tests__/data/user_transformation_service_filter_input.json
@@ -181,5 +181,67 @@
         }
       ]
     }
+  },
+  {
+    "message": {
+      "channel": "web",
+      "context": {
+        "app": {
+          "build": "1.0.0",
+          "name": "RudderLabs JavaScript SDK",
+          "namespace": "com.rudderlabs.javascript",
+          "version": "1.0.0"
+        },
+        "traits": {
+          "email": "test@rudderstack.com",
+          "anonymousId": "12345"
+        },
+        "library": {
+          "name": "RudderLabs JavaScript SDK",
+          "version": "1.0.0"
+        },
+        "userAgent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/77.0.3865.90 Safari/537.36",
+        "locale": "en-US",
+        "ip": "0.0.0.0",
+        "os": {
+          "name": "",
+          "version": ""
+        },
+        "screen": {
+          "density": 2
+        }
+      },
+      "type": "non-standard",
+      "messageId": "ec5481b6-a926-4d2e-b293-0b3a77c4d3be",
+      "originalTimestamp": "2019-10-14T11:15:18.300Z",
+      "anonymousId": "00000000000000000000000000",
+      "userId": "12345",
+      "event": "test track event GA3",
+      "properties": {
+        "user_actual_role": "system_admin, system_user",
+        "user_actual_id": 12345
+      },
+      "integrations": {
+        "All": true
+      },
+      "sentAt": "2019-10-14T11:15:53.296Z"
+    },
+    "metadata": {
+      "messageId": "ec5481b6-a926-4d2e-b293-0b3a77c4d3be",
+      "sourceId": "s1",
+      "destinationId": "d1"
+    },
+    "destination": {
+      "ID": 2,
+      "Config": {
+        "trackingID": "abcd"
+      },
+      "Enabled": true,
+      "Transformations": [
+        {
+          "VersionID": "24"
+        }
+      ]
+    }
   }
 ]
diff --git a/test/__tests__/data/user_transformation_service_filter_output.json b/test/__tests__/data/user_transformation_service_filter_output.json
@@ -68,6 +68,15 @@
         "destinationId": "d1"
       },
       "statusCode": 200
+    },
+    {
+      "error": "Error: non-standard event\n    at transformEvent (base transformation:5:56)",
+      "metadata": {
+        "destinationId": "d1",
+        "messageId": "ec5481b6-a926-4d2e-b293-0b3a77c4d3be",
+        "sourceId": "s1"
+      },
+      "statusCode": 400
     }
   ],
   "retryStatus": 200

diff --git a/test/__tests__/user_transformation_ts.test.ts b/test/__tests__/user_transformation_ts.test.ts
@@ -8,7 +8,7 @@ const name = 'User Transformations';
 const randomID = () => Math.random().toString(36).substring(2, 15);
 
 describe('User Transform Service', () => {
-  fit(`Filtering ${name} Test`, async () => {
+  it(`Filtering ${name} Test`, async () => {
     const versionId = '24'; // set in input file
     const inputData = require(`./data/${integration}_filter_input.json`);
     const expectedData = require(`./data/${integration}_filter_output.json`);
@@ -21,6 +21,7 @@ describe('User Transform Service', () => {
                 const eventType = event.type;
                 log(eventType);
                 log(eventType.match(/track/g));
+                if(eventType === 'non-standard') throw new Error('non-standard event');
                 if(eventType && !eventType.match(/track/g)) return;
                 return event;
               }