Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: openfaas pro reconcile fn over 1 dot 65 #3368

Closed

Conversation

abhimanyubabbar
Copy link
Contributor

What are the changes introduced in this PR?

Write a brief explainer on your code changes.

What is the related Linear task?

Resolves INT-XXX

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@abhimanyubabbar abhimanyubabbar requested review from a team and sivashanmukh as code owners May 13, 2024 09:37
@abhimanyubabbar abhimanyubabbar changed the title Chore/openfaas pro reconcile fn over 1 dot 65 chore: openfaas pro reconcile fn over 1 dot 65 May 13, 2024
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 95.52239% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 87.92%. Comparing base (be0e5f5) to head (5722ac2).
Report is 70 commits behind head on develop.

Files Patch % Lines
src/util/openfaas/index.js 93.33% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3368      +/-   ##
===========================================
+ Coverage    87.87%   87.92%   +0.04%     
===========================================
  Files          558      561       +3     
  Lines        30062    30204     +142     
  Branches      7194     7230      +36     
===========================================
+ Hits         26418    26557     +139     
- Misses        3341     3344       +3     
  Partials       303      303              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented May 13, 2024

@devops-github-rudderstack
Copy link
Contributor

This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants