Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

%to-json fails on strings which aren't simple #40

Closed
fisxoj opened this issue Oct 9, 2016 · 1 comment
Closed

%to-json fails on strings which aren't simple #40

fisxoj opened this issue Oct 9, 2016 · 1 comment

Comments

@fisxoj
Copy link
Contributor

fisxoj commented Oct 9, 2016

I was working on something using mito and my strings from postgres were coming back as (vector character)s. Despite there being a ((string string)) method for %to-json, it actually requires strings to be simple-string in %write-string.

I have a solution that creates two methods, one for simple-string that does what the current string method does, and another on string that prints the string into a new simple-string. I'll post that, shortly.

fisxoj added a commit to fisxoj/jonathan that referenced this issue Oct 9, 2016
Fixes rudolph-miller#40 by adding a method on `simple-string`
and changing `string`'s method to use a slower way, but not error.
@rudolph-miller
Copy link
Owner

Thank you to report.
I'll review your pull-request then. :octocat:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants