Improve character encoding. #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmccombs
force-pushed
the
safe-string-to-bytes
branch
from
f6de4b9
to
c2f3381
Compare
This includes two fixes: 1. Correctly encode control characters using \u notation, as described by the JSON specification. 2. Encode characters using UTF-8 when :octets is true. Previously non-ASCII characters either caused invalid JSON or threw an error.
tmccombs
force-pushed
the
safe-string-to-bytes
branch
from
c2f3381
to
988745f
Compare
Because ABCL (and Java) uses utf-16 internally, so non-BMP character are represented with surrogate pairs.
|
it seems like cl-coveralls (or really sb-cover) has trouble identifying coverage of inlined functions, or something. |
|
I know this problem. |
|
What needs to happen to get this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes two fixes:
by the JSON specification.
non-ASCII characters either caused invalid JSON or threw an error.