Unicode surrogate parsing was fixed. #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, jonathan considered the length of escaped surrogate pair is 11, but actually it is 10. Because of this error, jonathan eat the character followed the surrogate pair or raised an error if there is another surrogate pair goes right after the first one.
|
@rudolph-miller how about merging this pull? |
|
@rudolph-miller any news? |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, jonathan considered the length of escaped surrogate pair is 11, but actually it is 10.
Because of this error, jonathan eat the character followed the surrogate pair or raised an error if
there is another surrogate pair goes right after the first one.
This pull fixes issue #52
Also, it includes pull #37