Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fine tune for intercom XL camera #33

Closed
wants to merge 2 commits into from

Conversation

350d
Copy link
Contributor

@350d 350d commented Aug 19, 2023

  • max fps
  • image snapshot link

+ max fps
+ image snapshot link
Fix for "No trailing CRLF found in HTTP header. Adding it." warning
@rudyberends
Copy link
Owner

rudyberends commented Aug 24, 2023

i will adjust the max fps to match your setting.

I cannot merge this as the image snapshot link will break V2 compatibility. The intercomv2 does not have this image url.
Does it really make a difference using this image url vs the video url? If it really is, then we can implement a check where V1 intercoms will default to this image url.

@350d
Copy link
Contributor Author

350d commented Aug 24, 2023

Ok, keep the original url. I've tested it against static jpg and there is no big difference:
jpg:

0.02s user 0.01s system 12% cpu 0.241 total
bench: utime=0.004s stime=0.002s rtime=0.013s
bench: maxrss=10776576kB

mjpeg:

0.02s user 0.02s system 11% cpu 0.369 total
bench: utime=0.004s stime=0.002s rtime=0.011s
bench: maxrss=10797056kB

@rudyberends
Copy link
Owner

I kept the original url. The other changes are in the latest beta. I will close this request without merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants