Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: for mloginfo --queries round mean (ms) and 95%-ile (ms) to integers #698

Closed
niccottrell opened this issue Jun 25, 2019 · 0 comments
Assignees
Milestone

Comments

@niccottrell
Copy link

It seems that we don't need all this precision for means since at least for the top queries, we probably have a large count and quite a bit of variance. The simplicity and readability of rounding to a whole integer should outweigh any benefits of the precision.

Expected behavior

QUERIES
                                                                                          
namespace                                                         operation        pattern                                                                                                                                                                                                                                                                                                                                                                           count    min (ms)    max (ms)   mean (ms)     95%-ile (ms)          sum (ms)

server.timesheets                                                 find             {"clockOutTime": 1, "storeId": 1}                                                                                                                                                                                                                                                                                                                                                  2060         959        3494     1098      1373    2262352
server.businesses                                                 find             {"name": 1}                                                                                                                                                                                                                                                                                                                                                                        3615         100        9337     584      2033    2114251
server.Products_vapebosspj                                        count            {"$or": [{"title": {"$regex": 1}}, {"skuNumber": {"$regex": 1}}, {"barcode": {"$regex": 1}}], "isDeleted": {"$ne": 1}}                                                                                                                                                                                                                                                               19         132      208025        49649        205407    943331

Actual/current behavior

QUERIES
                                                                                          
namespace                                                         operation        pattern                                                                                                                                                                                                                                                                                                                                                                           count    min (ms)    max (ms)    mean (ms)             95%-ile (ms)          sum (ms)

server.timesheets                                                 find             {"clockOutTime": 1, "storeId": 1}                                                                                                                                                                                                                                                                                                                                                  2060         959        3494    1098.2291262135923               1373.05    2262352
server.businesses                                                 find             {"name": 1}                                                                                                                                                                                                                                                                                                                                                                        3615         100        9337     584.8550484094053    2033.5999999999967    2114251
server.Products_vapebosspj                                        count            {"$or": [{"title": {"$regex": 1}}, {"skuNumber": {"$regex": 1}}, {"barcode": {"$regex": 1}}], "isDeleted": {"$ne": 1}}                                                                                                                                                                                                                                                               19         132      208025               49649.0              205407.8    943331
@stennie stennie added this to the 1.6.1 milestone Dec 28, 2019
stennie added a commit to stennie/mtools that referenced this issue Dec 28, 2019
@stennie stennie self-assigned this Dec 28, 2019
bugre added a commit to bugre/mtools that referenced this issue Jan 5, 2020
…_JSONSerialize_crash_w_bytes

* 'develop' of github.com:bugre/mtools:
  Add VSCode config to .gitignore
  Bump dev version
  Update for 1.6.1 release
  Fix Flake8 complaints
  Fix rueckstiess#765: mloginfo --clients: more robust parsing of client metadata (rueckstiess#766)
  Fix rueckstiess#761: mtools should use python3 in shebangs
  Fix rueckstiess#698: Add rounding option for mloginfo --queries (rueckstiess#758)
  More specific match for checkpoint duration log line
  Fix rueckstiess#258: Add timezone to mloginfo summary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants