Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log slow checkpoints (mplotqueries --checkpoints) #707

Closed
mitesh-gosavi opened this issue Jul 2, 2019 · 0 comments
Closed

Log slow checkpoints (mplotqueries --checkpoints) #707

mitesh-gosavi opened this issue Jul 2, 2019 · 0 comments

Comments

@mitesh-gosavi
Copy link
Contributor

Expected behavior

mplotqueries —checkpoint flag should provide a scatterplot of all the slow checkpoints along with their duration and timestamp.

Actual/current behavior

mTools does not currently log any slow checkpoints. This issue focuses on logging the slow checkpoints (greater than 1 second). Log lines for slow checkpoints were added as a fix in versions 4.1.12 (For reference, see SERVER-16176). mTools currently skips these lines and does not parse or plot them.

Steps to reproduce the actual/current behavior

mplotqueries —checkpoint flag can be added to the argument parser. The parser on receiving the —checkpoint flag can search for log lines containing the “Checkpoint took” token (for reference, see mongodb/mongo@f3eb442). On encountering the token, the parser can parse the token after “took” and typecast it to an integer to get the duration.

Environment

Software Version
mtools 1.5.3
MongoDB server 4.0.10
savinay-vijay added a commit to savinay-vijay/mtools that referenced this issue Jul 2, 2019
savinay-vijay added a commit to savinay-vijay/mtools that referenced this issue Jul 3, 2019
savinay-vijay added a commit to savinay-vijay/mtools that referenced this issue Jul 3, 2019
savinay-vijay added a commit to savinay-vijay/mtools that referenced this issue Jul 8, 2019
@stennie stennie changed the title Log Slow Checkpoints Log Slow Checkpoints (mplotqueries --checkpoints) Dec 27, 2019
@stennie stennie added this to the 1.6.0 milestone Dec 27, 2019
@stennie stennie changed the title Log Slow Checkpoints (mplotqueries --checkpoints) Log slow checkpoints (mplotqueries --checkpoints) Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants