Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mloginfo --clients is missing old nodejs clients #808

Closed
niccottrell opened this issue Jul 2, 2020 · 2 comments
Closed

mloginfo --clients is missing old nodejs clients #808

niccottrell opened this issue Jul 2, 2020 · 2 comments
Assignees
Labels
Milestone

Comments

@niccottrell
Copy link

Expected behavior

Log lines like the following should show up in the final summary output:

2020-07-02T13:37:12.208+0000 I NETWORK  [conn202099] received client metadata from 192.168.181.44:36650 conn202099: { driver: { name: "nodejs", version: "2.2.36" }, os: { type: "Linux", name: "linux", architecture: "x64", version: "3.10.0-1062.12.1.el7.x86_64" }, platform: "Node.js v8.16.0, LE, mongodb-core: 2.1.20" }

Actual/current behavior

These lines are not included in the result

Steps to reproduce the actual/current behavior

run mloginfo --clients on a file with that log line

Environment

Software Version
mtools 1.6.3
Python 3.7.6
MongoDB server 3.6
Operating system macOS
@niccottrell
Copy link
Author

Looks like valid JSON to me:

{
  driver: {
    name: "nodejs",
    version: "2.2.36"
  },
  os: {
    type: "Linux",
    name: "linux",
    architecture: "x64",
    version: "3.10.0-1062.12.1.el7.x86_64"
  },
  platform: "Node.js v8.16.0, LE, mongodb-core: 2.1.20"
}

@stennie stennie added this to the 1.6.4 milestone Jul 3, 2020
@stennie stennie self-assigned this Jul 3, 2020
@stennie stennie added bug and removed question labels Jul 3, 2020
@stennie stennie closed this as completed in 285134a Jul 3, 2020
@stennie
Copy link
Collaborator

stennie commented Jul 3, 2020

Hi @niccottrell,

mloginfo --clients converts the raw output into valid JSON which includes quoting the field names. The regex wasn't expecting commas in the platform value.

I committed a fix for mtools 1.6.4.

Cheers,
Stennie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants