Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work #1843

Closed
wolfe4656 opened this issue Dec 4, 2020 · 28 comments
Closed

Does not work #1843

wolfe4656 opened this issue Dec 4, 2020 · 28 comments

Comments

@wolfe4656
Copy link

Your bug reporting is worthless. The plugin crashes.

@rdrpenguin04
Copy link
Contributor

Could you please give an example of something the plugin crashes on? Thanks!

@wolfe4656
Copy link
Author

wolfe4656 commented Dec 4, 2020 via email

@parkerlreed
Copy link

There is no attachment coming through on the GitHub issues page.

@wolfe4656
Copy link
Author

wolfe4656 commented Dec 4, 2020 via email

@rdrpenguin04
Copy link
Contributor

Where did you post them?

@wolfe4656
Copy link
Author

#1843

@wolfe4656
Copy link
Author

I dont see them either and i also attached them to my email response.

@wolfe4656
Copy link
Author

wolfe4656 commented Dec 4, 2020 via email

@wolfe4656
Copy link
Author

i am attaching again. under preview.
Ruffle error 2
Ruffle error

@wolfe4656
Copy link
Author

I will try again.
Ruffle error 2
Ruffle error

@wolfe4656 wolfe4656 reopened this Dec 4, 2020
@rdrpenguin04
Copy link
Contributor

Why did you close the report?

@wolfe4656
Copy link
Author

in error

@wolfe4656
Copy link
Author

hit the worng button.

@rdrpenguin04
Copy link
Contributor

Anyways, the error looks like GL_INVALID_VALUE. I'll look at the code quick.

@wolfe4656
Copy link
Author

Thanks

@rdrpenguin04
Copy link
Contributor

rdrpenguin04 commented Dec 4, 2020

@Herschel One of two things is happening here:

  1. self.msaa_sample_count is higher than supported by some systems; this could be caught and fixed potentially.
  2. width or height is greater than gl.MAX_RENDERBUFFER_SIZE; this can definitely be checked, but I don't know what the best thing to do if this isn't supported is.

@wolfe4656
Copy link
Author

It is a online NVR camera system with 16 channels. That could be why.

@rdrpenguin04
Copy link
Contributor

The camera shouldn't have anything to do with it.

@Herschel
Copy link
Member

Herschel commented Dec 4, 2020

@rdrpenguin04 gl MAX_SAMPLES is already checked, and gl.drawingBufferWidth is used to ensure we don't make a renderbuffer bigger than what the browser gives us. Originally I had added a check for MAX_RENDERBUFFER_SIZE in #1787 but I took it out as it didn't specifically seem to help much. (The issue with most of these parameters is that they can lie, or don't really give you enough info to know under which conditions things will fail).

@wolfe4656 What is the version number of the Ruffle build you are using? You should be able to paste the full text from the error dialog into this issue, which includes the version.

Also if your Flash file requires support for video (cameras), it may not function in Ruffle because video is not supported yet. Thanks for the report!

@wolfe4656
Copy link
Author

the plugin for chrome is Ruffle 0.1.0. That could be why too i thik the flash is required with the video. It will not allow me to copy the text from the error log.

@Herschel
Copy link
Member

Herschel commented Dec 4, 2020

Specifically I'm looking for to build date for the Ruffle build (all of the info under Ruffle Info). Is it the latest nightly build?

@wolfe4656
Copy link
Author

Where can i find the build info?
Version
0.1.0
Size
3.6 MB
ID
nbamcodkicaamabefdobidlhlhkjhcoc
Inspect views
No active views
Permissions
Site access
Allow this extension to read and change all your data on websites you visit:
On click
On specific sites
On all sites
Allow in incognito
Warning: Google Chrome cannot prevent extensions from recording your browsing history. To disable this extension in incognito mode, unselect this option.
Allow access to file URLs
Collect errors
Extension options
Source
Unpacked extension
Loaded from: E:\Downloads\Flashpoint Adobe flash repl\Flash repl for browser ruffle\ruffle_nightly_2020_11_20_extension

@rdrpenguin04
Copy link
Contributor

ruffle_nightly_2020_11_20_extension <-- And there we have it!

@parkerlreed
Copy link

Update. There's a 12/04 nightly

@wolfe4656
Copy link
Author

Better i get a black screen now with 12/04.
This SWF contains ActionScript 3 which is not yet supported by Ruffle. The movie may not work as intended.

@Herschel
Copy link
Member

Herschel commented Dec 4, 2020

ActionScript 3 support is still a work in progress, sorry for the trouble. Closing in favor of #1843.

@Herschel Herschel closed this as completed Dec 4, 2020
@parkerlreed
Copy link

Closing in favor of this same issue? :P

@Herschel
Copy link
Member

Herschel commented Dec 4, 2020

Oops :-) Closing in favor of #1368

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants