Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapping is broken in rust nightlies #579

Closed
Dinnerbone opened this issue May 13, 2020 · 2 comments · Fixed by #582
Closed

Wrapping is broken in rust nightlies #579

Dinnerbone opened this issue May 13, 2020 · 2 comments · Fixed by #582

Comments

@Dinnerbone
Copy link
Contributor

Run cargo test to verify.

---- avm1::value::test::wrapping_i16 stdout ----
thread 'avm1::value::test::wrapping_i16' panicked at 'assertion failed: `(left == right)`
  left: `-1`,
 right: `0`', core/src/avm1/value.rs:874:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- avm1::value::test::wrapping_u16 stdout ----
thread 'avm1::value::test::wrapping_u16' panicked at 'assertion failed: `(left == right)`
  left: `65535`,
 right: `0`', core/src/avm1/value.rs:856:9

It seems to be that float-to-int has changed behaviour.

@Herschel
Copy link
Member

Have a fix incoming in 1 minute :-)

@Dinnerbone
Copy link
Contributor Author

Haha fair enough! I figured I'd open an issue so we don't forget :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants