Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[regression] animation wrong displayed in full screen without hardware acceleration #7533

Closed
ousia opened this issue Aug 1, 2022 · 11 comments
Labels
bug Something isn't working

Comments

@ousia
Copy link
Contributor

ousia commented Aug 1, 2022

Describe the bug

In both Linux and Windows, when hardware acceleration isn’t available, the presentation contained in https://www.free-culture.tk/ is displayed in a totally wrong way:

fes

Expected behavior

Compare it to the real page:

fase

I cannot say when the regression was introduced, but this was displayed fine until recently (I think).

Affected platform

Browser's extension

Operating system

Linux

Browser

Firefox 103

@n0samu
Copy link
Member

n0samu commented Aug 2, 2022

Can confirm this issue:
image

The screen appears blank most of the time because the text is somehow rendering mostly off-screen.

@n0samu
Copy link
Member

n0samu commented Aug 2, 2022

Strangely, the issue does not occur on the Ruffle extension's internal player page. To figure out what the difference was, I tried disabling the CSS on your site, loading the extension copy of Ruffle into the page and removing the explicit width and height from your Flash embed. Yet the issue still occurs.

@ousia
Copy link
Contributor Author

ousia commented Aug 3, 2022

Strangely, the issue does not occur on the Ruffle extension's internal player page.

Many thanks for your help, @n0samu.

Do you mean https://ruffle.rs/demo/?

If I drag and drop https://www.free-culture.tk/lfc-presentation.swf over https://ruffle.rs/demo/, once I enable fullscreen mode (pressing f), fullscreen image is distorted.

This is not as distorted as in https://www.free-culture.tk/, because the original frame in this case is much smaller.

And again, this only happens with hardware acceleration disabled.

Or the distortion may occur when fullscreen is disabled again (if animation in fullscreen was displayed fine).

For some strange reason, image seems not to be recalculated again when changing fullscreen and normal modes.

I would be very surprised if this were the only animation that displays the issue.

Many thanks for your help again.

@n0samu
Copy link
Member

n0samu commented Aug 6, 2022

Do you mean https://ruffle.rs/demo/?

No, I meant the Ruffle browser extension (I was using the Firefox extension). If you enable the browser extension and open the SWF URL directly, it will open in the extension's internal player page.

@ousia
Copy link
Contributor Author

ousia commented Aug 10, 2022

I think this regression may be a Firefox issue drawing the frames.

I’m not on Windows now, but Chrome seems not to have any issue displaying the presentation.

Thanks to https://sourceforge.net/projects/portableapps/files/Mozilla Firefox Developer Portable/, I was able to test https://www.free-culture.tk with Firefox 99 (beta 1) and with Firefox 104 (beta 1).

The issue arises when hardware acceleration is disabled (or not available):

  1. Image is displayed perfectly fine with version 99.
  2. Version 104 doesn’t seem to display image at all when in full-screen.

All this happened using the browser extension from the nightly build from today (2022-08-10).

So it is highly improbable that the regression was caused by Ruffle itself (I guess Firefox may be messing things here).

@n0samu, I updated the selfhosted build to the nightly from today.

Would you be so kind to check it with Chrome?

Many thanks for your help.

PS: I’m checking now with Firefox for Linux with hardware acceleration disabled (https://www.free-culture.tk/lfc-presentation.swf). I’m afraid that I have just realized get what was working fine for you, @n0samu (😅).

@ousia
Copy link
Contributor Author

ousia commented Aug 10, 2022

@n0samu,

playing directly https://www.free-culture.tk/lfc-presentation.swf, I get a first image such as:

beforefullscreen

It will be scaled perfectly fine to full screen (to the same image I already attached).

But going back to normal size distorts the image:

backtonormal

Again, I’m on Linux using Firefox with the nightly browser extension from 2022-08-10.

Clearer sample?

With a very similar presentation, https://www.improve-presentations.tk/Presentacion-presentation.swf:

The first image is fine:

before

Full screen is also fine:
fs-fine

But back to normal gets distorsion:

after-distorted

Just in case it helps.

@ousia
Copy link
Contributor Author

ousia commented Aug 11, 2022

After checking myself the presentation in Chrome (same computer as the original issue reported here), image is rasterized fine in both full and normal screen.

So the culprit seems to be Firefox rasterizing the images from frames.

BTW, this is what Firefox displays after setting the image to normal after full screen:

Untistled

The animation is actually played in the bottom left corner, having the main image flickering but not advancing with the slides.

I think this may be be an upstream issue with Firefox, but I don’t know where to start or how to report this.

@ousia
Copy link
Contributor Author

ousia commented Aug 11, 2022

Just it case it might help, here you have the resource info:

ffox-img

  1. Top left: Chrome in full screen.
  2. Top right: Chrome in normal screen.
  3. Bottom left: Firefox in full screen.
  4. Bottom right: Firefox in normal screen.

The animation played was https://www.free-culture.tk.

Just in case it might help.

@ousia
Copy link
Contributor Author

ousia commented Aug 30, 2022

@Dinnerbonne,

sorry for bothering you here, but I’d avoid polluting the PR with comments that may not be related.

I guess that #7777 is not related to non-hardware accelerated graphics.

I wanted to know just to see if this could be improved in any way (or it could be a good test case for the PR).

Many thanks for your help.

@ousia
Copy link
Contributor Author

ousia commented Oct 22, 2022

This seems to be fixed in latest Firefox (106.0.1).

Closing the issue myself, although it would be great if @n0samu could confirm the fix too.

@ousia ousia closed this as completed Oct 22, 2022
@n0samu
Copy link
Member

n0samu commented Oct 23, 2022

Can confirm that this is fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants