avm1: Fix removeMovieClip depth range #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removeMovieClip should only function on objects within a certain depth range, usually to prevent removing timeline clips. However, this wasn't working properly in some cases because the depth was being biased incorrectly (removeMovieClip never takes a depth parameter, so we should not bias the depth).
Herschel
force-pushed
the
remove-movie-clip-fix
branch
from
3b7d822
to
e496ddb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removeMovieClip should only function on objects within a certain
depth range, usually to prevent removing timeline clips. However,
this wasn't working properly in some cases because the depth was
being biased incorrectly. This would allow some clips to be removed
when they wouldn't be in the Flash Player.
This fixes the "Start Game" buttons not appearing in Proximity (https://www.newgrounds.com/portal/view/183428), which was cause by a remove-all-clips loop on the main menu (cc #923).