Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug_ui: Indent non-expandable items in object- and display trees #12467

Merged

Conversation

torokati44
Copy link
Member

@torokati44 torokati44 commented Jul 31, 2023

This confused me terribly.

Before (single item, instance2, collapsed/expanded):

image image

After (same item collapsed/expanded):

image image

Note also how the cyan Graphic item at the bottom is now at the same indentation level as MovieClip "water_mc", and not as the green MovieClip at the top. I feel like this makes more sense, as the former is its sibling, while the latter is its parent.

@torokati44
Copy link
Member Author

torokati44 commented Jul 31, 2023

Yes, this does mean that basically every level of the tree hierarchy is effectively two indentation levels.
One is to show the child relationship (which was already there), and one is to keep the alignment the same between collapsible and non-collapsible children.

I would prefer if the first one could be omitted (with the expand buttons scooted to the left a bit), but saw no way to do that. No, actually, I think this is fine as is. Oh, since this only affects leaves, it can't actually alter the overall indentation depth by more than one.

Copy link
Contributor

@Dinnerbone Dinnerbone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no strong feelings about this. Sure thing.

@torokati44
Copy link
Member Author

I have no strong feelings about this.

Huhh, that's so strange to hear. :D The second screenshot, when looked at in itself, at least to me, clearly means that "water_mc" has 4 children, 1 MovieClip (with a funky expand triangle, granted) and 3 Graphics.

Sure thing.

Anyway, I'm glad you don't oppose it either! ^^

@Dinnerbone
Copy link
Contributor

Huhh, that's so strange to hear. :D The second screenshot, when looked at in itself, at least to me, clearly means that "water_mc" has 4 children, 1 MovieClip (with a funky expand triangle, granted) and 3 Graphics.

Somewhat disagree. The line does that, to me 😅 Now there's clearly an extra indent that isn't associated with anything.

@torokati44
Copy link
Member Author

torokati44 commented Jul 31, 2023

The line does that, to me 😅

Huh, you mean this line? :D
image

I always consider whatever is there just meaningless decoration clutter. 😅

My brain be like: "icon at same x position -> nodes at same tree depth"

@torokati44 torokati44 changed the title debug_ui: Indent non-expandable object tree items debug_ui: Indent non-expandable items object- and display trees Aug 1, 2023
@Dinnerbone Dinnerbone enabled auto-merge (rebase) August 2, 2023 08:11
@Dinnerbone Dinnerbone merged commit 515df16 into ruffle-rs:master Aug 2, 2023
13 checks passed
@torokati44
Copy link
Member Author

Thank you for the merge! ^^

@torokati44 torokati44 changed the title debug_ui: Indent non-expandable items object- and display trees debug_ui: Indent non-expandable items in object- and display trees Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants