web: Include wasm file in docker builds as Mozilla say this is okay #15294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dinnerbone
force-pushed
the
docker_wasm
branch
from
17a661d
to
82a98f1
Compare
Dinnerbone
force-pushed
the
docker_wasm
branch
from
82a98f1
to
31653b9
Compare
svix-aaron1011
approved these changes
Feb 22, 2024
Aaron1011
approved these changes
Feb 22, 2024
…and it solves our reproducibility issues
Dinnerbone
force-pushed
the
docker_wasm
branch
from
31653b9
to
6e64a9d
Compare
This was referenced Feb 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a solution to the reproducible extension issue.
Unexpected, but allowed. We'll include the wasm in the source we send them, and then the JS will match.
The final wasm files inside the build they make will not match, until rustwasm/wasm-bindgen#3851 - we're told this is okay though, so I've just removed the wasm-opt step too for brevity.