core: Default value logic for MovieClip.tabEnabled
#15618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
force-pushed
the
tab-ordering-movieclip
branch
from
79313a5
to
40a09e3
Compare
danielhjacobs
added
avm1
kjarosh
force-pushed
the
tab-ordering-movieclip
branch
2 times, most recently
from
87141be
to
5880d85
Compare
danielhjacobs
added
the
waiting-on-review
kjarosh
force-pushed
the
tab-ordering-movieclip
branch
3 times, most recently
from
ace333a
to
3439ba2
Compare
Lord-McSweeney
approved these changes
Mar 29, 2024
kjarosh
force-pushed
the
tab-ordering-movieclip
branch
2 times, most recently
from
c1e1b11
to
d4671d5
Compare
The default value of `MovieClip.tabEnabled` is neither trivial nor well-documented. This patch implements the logic behind the default value of `MovieClip.tabEnabled` and covers it with tests.
This test verifies the logic behind the default value of `MovieClip.tabEnabled` when it's undefined.
torokati44
force-pushed
the
tab-ordering-movieclip
branch
from
d4671d5
to
3b9ed5c
Compare
Lord-McSweeney
removed
the
waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5443.
The default value of
MovieClip.tabEnabledis neither trivial nor well-documented. This patch implements the logic behind the default value ofMovieClip.tabEnabledand covers it with tests.