Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unused dependencies #15769

Merged

Conversation

sleepycatcoding
Copy link
Member

No description provided.

Copy link
Member

@torokati44 torokati44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't imagine anything breaking if CI passes.

@torokati44
Copy link
Member

torokati44 commented Mar 25, 2024

The lint check failure seems unrelated, and will probably be fixed by mitsuhiko/insta#461.

BTW, cargo-udeps says:

unused dependencies:
`build_playerglobal v0.1.0 (/home/attila/projects/ruffle/core/build_playerglobal)`
└─── dependencies
     ├─── "colored"
     └─── "serde-xml-rs"
`ruffle_render v0.1.0 (/home/attila/projects/ruffle/render)`
└─── dependencies
     └─── "lru"
`ruffle_render_canvas v0.1.0 (/home/attila/projects/ruffle/render/canvas)`
└─── dependencies
     └─── "fnv"
`ruffle_render_webgl v0.1.0 (/home/attila/projects/ruffle/render/webgl)`
└─── dependencies
     └─── "fnv"
`ruffle_web v0.1.0 (/home/attila/projects/ruffle/web)`
└─── dependencies
     └─── "ruffle_render_wgpu"
`ruffle_web_safari v0.1.0 (/home/attila/projects/ruffle/web/packages/extension/safari)`
└─── dependencies
     └─── "objc"

@sleepycatcoding
Copy link
Member Author

sleepycatcoding commented Mar 25, 2024

The lint check failure seems unrelated.

BTW, cargo-udeps says:

unused dependencies:
`build_playerglobal v0.1.0 (/home/attila/projects/ruffle/core/build_playerglobal)`
└─── dependencies
     ├─── "colored"
     └─── "serde-xml-rs"
`ruffle_render v0.1.0 (/home/attila/projects/ruffle/render)`
└─── dependencies
     └─── "lru"
`ruffle_render_canvas v0.1.0 (/home/attila/projects/ruffle/render/canvas)`
└─── dependencies
     └─── "fnv"
`ruffle_render_webgl v0.1.0 (/home/attila/projects/ruffle/render/webgl)`
└─── dependencies
     └─── "fnv"
`ruffle_web v0.1.0 (/home/attila/projects/ruffle/web)`
└─── dependencies
     └─── "ruffle_render_wgpu"
`ruffle_web_safari v0.1.0 (/home/attila/projects/ruffle/web/packages/extension/safari)`
└─── dependencies
     └─── "objc"

Do I add them to this PR? Actually we cannot remove the objc dependency from ruffle_web_safari since that is actually used, but only when the target is MacOS.

@torokati44
Copy link
Member

torokati44 commented Mar 25, 2024

Do I add them to this PR?

However you feel like. I'm fine with merging this as is, or with those removals added.

@torokati44
Copy link
Member

Actually we cannot remove the objc dependency from ruffle_web_safari since that is actually used, but only when the target is MacOS.

To be fair, the tool also said:

Note: These dependencies might be used by other targets.
      To find dependencies that are not used by any target, enable `--all-targets`.
Note: They might be false-positive.
      For example, `cargo-udeps` cannot detect usage of crates that are only used in doc-tests.
      To ignore some dependencies, write `package.metadata.cargo-udeps.ignore` in Cargo.toml.

🙃

@torokati44 torokati44 changed the title chore: Remove unused dependencies from build_playerglobal chore: Remove unused dependencies Mar 25, 2024
Copy link
Member

@torokati44 torokati44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@torokati44 torokati44 merged commit 1b41abf into ruffle-rs:master Mar 25, 2024
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

2 participants