ci: Split cargo-deny into its own job, add cargo-machete

.github/workflows/test_rust.yml

@@ -31,7 +31,7 @@ jobs:
 
   build:
     needs: changes
-    if: needs.changes.outputs.should_run== 'true'
+    if: needs.changes.outputs.should_run == 'true'
     name: Test Rust ${{ matrix.rust_version }} / ${{ matrix.os }}
     runs-on: ${{ matrix.os }}
     continue-on-error: ${{ matrix.rust_version == 'nightly' || matrix.rust_version == 'beta' }}
@@ -103,7 +103,7 @@ jobs:
 
   lints:
     needs: changes
-    if: needs.changes.outputs.should_run== 'true'
+    if: needs.changes.outputs.should_run == 'true'
     name: Lints with Rust ${{ matrix.rust_version }}
     runs-on: ubuntu-22.04
     continue-on-error: ${{ matrix.rust_version == 'nightly' || matrix.rust_version == 'beta' }}
@@ -133,15 +133,31 @@ jobs:
         # Don't fail the build for clippy on nightly, since we get a lot of false-positives
         run: cargo clippy --all --all-features --tests ${{ (matrix.rust_version != 'nightly' && '-- -D warnings') || '' }}
 
-      - name: Check licensing and duplicates in used crates
-        if: ${{ matrix.rust_version == 'stable' }}
-        uses: EmbarkStudios/cargo-deny-action@v1
-
       - name: Check documentation
         run: cargo doc --no-deps --all-features
         env:
           RUSTDOCFLAGS: -D warnings
 
+  dependencies:
+    needs: changes
+    if: needs.changes.outputs.should_run == 'true'
+    name: Check dependencies
+    runs-on: ubuntu-22.04
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Install Rust toolchain
+        uses: dtolnay/rust-toolchain@stable
+
+      - name: Check licenses, duplicates, and advisories
+        uses: EmbarkStudios/cargo-deny-action@v1
+
+      - name: Check unused dependencies
+        uses: bnjbvr/cargo-machete@main
+        # So the previous step failing doesn't prevent this one from running.
+        if: always()
+
   check-required:
     needs: changes
     if: needs.changes.outputs.should_run == 'false'

exporter/Cargo.toml

@@ -16,7 +16,6 @@ futures = "0.3"
 ruffle_core = { path = "../core", features = ["deterministic", "default_font"] }
 ruffle_render_wgpu = { path = "../render/wgpu", features = ["clap"] }
 image = { version = "0.25.0", default-features = false, features = ["png"] }
-log = "0.4"
 walkdir = "2.5.0"
 indicatif = "0.17"
 rayon = "1.10.0"

render/canvas/Cargo.toml

@@ -17,7 +17,6 @@ ruffle_web_common = { path = "../../web/common" }
 wasm-bindgen = "=0.2.92"
 ruffle_render = { path = "..", features = ["web"] }
 swf = { path = "../../swf" }
-downcast-rs = "1.2.0"
 
 [dependencies.web-sys]
 version = "0.3.69"

render/naga-pixelbender/Cargo.toml

@@ -14,7 +14,5 @@ workspace = true
 ruffle_render = { path = "../" }
 naga = { workspace = true }
 naga_oil = { workspace = true }
-tracing = { workspace = true }
 anyhow = "1.0.81"
-bitflags = "2.5.0"
 

render/webgl/Cargo.toml

@@ -19,7 +19,6 @@ wasm-bindgen = "=0.2.92"
 bytemuck = { version = "1.15.0", features = ["derive"] }
 swf = { path = "../../swf" }
 thiserror = "1.0"
-downcast-rs = "1.2.0"
 
 [dependencies.web-sys]
 version = "0.3.69"

render/wgpu/Cargo.toml

@@ -15,7 +15,6 @@ wgpu = { workspace = true, features = ["naga-ir"] }
 tracing = { workspace = true }
 ruffle_render = { path = "..", features = ["tessellator", "wgpu"] }
 bytemuck = { version = "1.15.0", features = ["derive"] }
-raw-window-handle = "0.6.0"
 clap = { version = "4.5.4", features = ["derive"], optional = true }
 enum-map = "2.7.3"
 fnv = "1.0.7"
@@ -24,7 +23,6 @@ image = { version = "0.25.0", default-features = false }
 naga_oil = { workspace = true }
 naga-agal = { path = "../naga-agal" }
 naga-pixelbender = { path = "../naga-pixelbender" }
-downcast-rs = "1.2.0"
 profiling = { version = "1.0", default-features = false, optional = true }
 lru = "0.12.3"
 naga = { workspace = true }
@@ -44,3 +42,9 @@ render_debug_labels = []
 render_trace = ["wgpu/trace"]
 webgl = ["wgpu/webgl"]
 profile-with-tracy = ["profiling", "profiling/profile-with-tracy"]
+
+[package.metadata.cargo-machete]
+ignored = [
+    # Not used directly, declared only to enable its `profile-with-tracy` feature.
+    "profiling"
+]

tests/framework/Cargo.toml

@@ -11,7 +11,6 @@ version.workspace = true
 workspace = true
 
 [dependencies]
-futures = "0.3.30"
 ruffle_core = { path = "../../core", features = ["deterministic", "timeline_debug", "avm_debug", "audio", "mp3", "default_font"] }
 ruffle_render = { path = "../../render" }
 ruffle_input_format = { path = "../input-format" }

web/Cargo.toml

@@ -74,3 +74,9 @@ features = [
     "HtmlInputElement", "HtmlTextAreaElement", "KeyboardEvent", "Location", "PointerEvent",
     "Request", "RequestInit", "Response", "Storage", "WheelEvent", "Window", "ReadableStream", "RequestCredentials"
 ]
+
+[package.metadata.cargo-machete]
+ignored = [
+    # Not used directly, declared only to enable its `js` feature.
+    "getrandom"
+]