desktop: Add preference to change storage backend #15785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sleepycatcoding
force-pushed
the
in_memory_storage_backend
branch
3 times, most recently
from
391b13d
to
c55bf4a
Compare
Dinnerbone
reviewed
Apr 1, 2024
Dinnerbone
reviewed
Apr 1, 2024
sleepycatcoding
force-pushed
the
in_memory_storage_backend
branch
2 times, most recently
from
aef5887
to
80edfd0
Compare
Dinnerbone
approved these changes
Apr 3, 2024
sleepycatcoding
force-pushed
the
in_memory_storage_backend
branch
from
80edfd0
to
a83a767
Compare
torokati44
reviewed
Apr 8, 2024
| @@ -2268,8 +2268,8 @@ impl PlayerBuilder { | |||
|
|
|||
| /// Sets the storage backend of the player. | |||
| #[inline] | |||
| pub fn with_storage(mut self, storage: impl 'static + StorageBackend) -> Self { | |||
| self.storage = Some(Box::new(storage)); | |||
| pub fn with_storage(mut self, storage: Box<dyn StorageBackend>) -> Self { | |||
There was a problem hiding this comment.
Since Player and especially PlayerBuilder are kinda-sorta de-facto "public API", this broke the Android app:
https://github.com/ruffle-rs/ruffle-android/actions/runs/8599069910/job/23561194287#step:6:42
:/
I really wish this would have followed the pattern of with_renderer / with_boxed_renderer right above it.
Anyway, no big deal, I can fix it, this breakage just feels unnecessary and inconsistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #12943 and expands on it by adding it to preferences.
Unresolved questions:
Should we keep these preferences as
save, rename tostorageor something different entirely?