New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update README.md #15839
docs: Update README.md #15839
Conversation
turicfr
commented
Apr 2, 2024
- Mention the Android application of Ruffle and link to its build instructions
- Add missing folders in the sructure section
- Misc changes
e22ce5c
to
25193da
Compare
d6f4f16
to
4ee0244
Compare
README.md
Outdated
|
||
### Desktop | ||
|
||
If you are building for a Linux platform, the following are typical dependencies: | ||
#### Ubuntu | ||
#### Linux prerequisites |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strictly speaking, some of these are general linux prerequisites - not specifically desktop.
I know that's not new to this PR though :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth it to add a note that these are Ubuntu packages and that the names might not match with other flavors of Linux (e.g. Fedora), just for example #14654 (comment).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a Linux expert, but I know that at least Arch depends on alsa-lib
, openssl
, zlib
, and libxcb
. Might worth adding these as well?
Also, we might also want to delete default-jre-headless
from the list as Java is already present in the general prerequisites.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a Linux expert, but I know that at least Arch depends on
alsa-lib
,openssl
,zlib
, andlibxcb
. Might worth adding these as well?
libasound2
should be equivalent to alsa-lib
, I think it might be worth it to have separate lists for different flavors.
Also, we might also want to delete
default-jre-headless
from the list as Java is already present in the general prerequisites.
I think we can keep it in, no harm mentioning it twice, just in case the reader missed it the first time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Teeny tiny nit but otherwise thank you so much!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
* Mention the Android application of Ruffle and link to its build instructions * Add missing folders in the sructure section * Misc changes
a13777d
to
f331f7b
Compare