frontend-utils: Made new crate and moved bookmarks & all toml serialization utils to it #15865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(side note: the name is kinda clunky as a commit prefix... ugh) |
Dinnerbone
force-pushed
the
serialization
branch
from
4ae67c1
to
d84e7fe
Compare
sleepycatcoding
approved these changes
Apr 4, 2024
Comment on lines
+86
to
98
| fn find_table(toml_document: &mut DocumentMut) -> &mut ArrayOfTables { | ||
| if toml_document.contains_array_of_tables("bookmark") { | ||
| return toml_document["bookmark"] | ||
| .as_array_of_tables_mut() | ||
| .expect("type was just verified"); | ||
| } | ||
|
|
||
| fn get_underlying_table(&mut self) -> &mut ArrayOfTables { | ||
| if self.0.toml_document.contains_array_of_tables("bookmark") { | ||
| return self.0.toml_document["bookmark"] | ||
| tracing::warn!("missing or invalid bookmark array, recreating.."); | ||
| toml_document.insert("bookmark", array()); | ||
| toml_document["bookmark"] | ||
| .as_array_of_tables_mut() | ||
| .expect("type was just verified"); | ||
| .expect("type was just created") | ||
| } |
There was a problem hiding this comment.
side note: not related to the PR but I thought about making a WriteExt and have this as a get_or_create_... method there.
There was a problem hiding this comment.
That'd probably look quite nice! But I'll save it for a followup, yeah? :D
Comment on lines
+31
to
+38
| impl<T: Default> Default for DocumentHolder<T> { | ||
| fn default() -> Self { | ||
| Self { | ||
| toml_document: Default::default(), | ||
| inner: Default::default(), | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
clever 😄 (I meant the Deref, but my hands are not cooperating with me, selected wrong lines)
Dinnerbone
force-pushed
the
serialization
branch
from
d84e7fe
to
18ec743
Compare
…rences and bookmarks
Dinnerbone
force-pushed
the
serialization
branch
from
18ec743
to
04e17f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This crate will eventually serve as the shared code between desktop and android (and any other future frontend), so we don't need to keep reinventing things over and over.
This PR just moves all the serialization utils to it (with cleanups), but followup PRs will add more things such as per-swf launch settings.