avm2: Allow splice() on a Vector with fixed=true #16010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evilpie
reviewed
Apr 16, 2024
adrian17
force-pushed
the
avm2-no-fixed-exception-on-splice
branch
2 times, most recently
from
3c32a88
to
df759b7
Compare
evilpie
approved these changes
Apr 16, 2024
|
(Yeah, stating the obvious, but: Looks like there's a "last empty line" mismatch between the expected and actual outputs.) |
adrian17
force-pushed
the
avm2-no-fixed-exception-on-splice
branch
2 times, most recently
from
68a96d7
to
759ee33
Compare
adrian17
force-pushed
the
avm2-no-fixed-exception-on-splice
branch
from
759ee33
to
5a96a2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16007 .