avm2: Remove outdated TODO comments #16035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lord-McSweeney
commented
Apr 19, 2024
| @@ -903,9 +903,6 @@ pub fn set_scroll_rect<'gc>( | |||
| object_to_rectangle(activation, rectangle)?, | |||
| ); | |||
|
|
|||
| // TODO: Technically we should accept only `flash.geom.Rectangle` objects, in which case | |||
| // `object_to_rectangle` will be infallible. Once this happens, the following line can | |||
There was a problem hiding this comment.
the following line can be moved above the
set_next_scroll_rectcall.
I didn't see the point in doing that, so I left it as-is.
adrian17
reviewed
Apr 19, 2024
| @@ -34,8 +34,6 @@ pub enum Hint { | |||
| } | |||
|
|
|||
| /// An AVM2 value. | |||
| /// | |||
| /// TODO: AVM2 also needs Scope, Namespace, and XML values. | |||
There was a problem hiding this comment.
this comment isn't entirely irrelevant, as in: IIRC FP does have a primitive type for namespaces. I don't really understand why or if it can ever matter, so yeah let's drop it :)
adrian17
approved these changes
Apr 19, 2024
Lord-McSweeney
force-pushed
the
avm2-minor-fixes
branch
from
468a657
to
8b22f5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.