Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

desktop: Skip waiting for resize event after resize fails #16170

Merged
merged 2 commits into from
May 6, 2024

Conversation

colin969
Copy link
Contributor

@colin969 colin969 commented Apr 30, 2024

Under hyprland tiling window manager, the resize event fails and the loading stops until the user manually resizes the window to trigger a resize event.

This should fix that by not waiting for a resize event to continue loading if we know the resize failed.

The resize also fails even if the window is floating, so that may be something worth looking into separately.

desktop/src/app.rs Outdated Show resolved Hide resolved
Copy link
Member

@torokati44 torokati44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No regressions found on Wayland (KDE or Weston), nor in XWayland (KDE), and it makes sense, plus I believe you that this fixes a use case, so in it goes, thanks!

@torokati44 torokati44 enabled auto-merge (squash) May 6, 2024 09:34
@torokati44 torokati44 merged commit 12bc0b7 into ruffle-rs:master May 6, 2024
17 checks passed
@torokati44
Copy link
Member

It would have been better to test on Windows too, but I'm like 98.4% certain that it won't cause any issues there...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants