web: Don't append and subsequently remove link just to download files #16185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
approved these changes
May 1, 2024
danielhjacobs
force-pushed
the
dont-append-link
branch
from
8bfb59f
to
e7fe4bc
Compare
danielhjacobs
force-pushed
the
dont-append-link
branch
from
e7fe4bc
to
613249c
Compare
danielhjacobs
force-pushed
the
dont-append-link
branch
from
613249c
to
74148a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
download_as_filefunction in #16178, which is theweb_sysversion of this function just with&[u8]as input instead of a blob, made me realize this is unnecessary as it's not done in that function.