avm2: share binding skip optimization with call_method
#16197
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shares the optimization from
call_property
which skips binding methods that don't need receivers withcall_method
. Currently, for example, Chess Demons allocates almost 1GB of unnecessary function objects during loading, this patch fixes that:A quick
perf stat
run shows a small decrease in loading time and page faults cut in half:Thanks to @adrian17 for figuring out the problem and suggesting this fix!