Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug_ui: Exclude hidden objects properly when searching #16260

Merged
merged 1 commit into from
May 9, 2024

Conversation

kjarosh
Copy link
Member

@kjarosh kjarosh commented May 8, 2024

The option "Include Hidden" was not working properly, as it did not exclude all hidden objects when disabled. An object is hidden also when its ancestor is not visible.

Before After

@torokati44
Copy link
Member

Does the same thing apply with "Only Mouse Enabled Objects"?

@kjarosh
Copy link
Member Author

kjarosh commented May 9, 2024

Does the same thing apply with "Only Mouse Enabled Objects"?

Hmmm... I don't think the same thing applies to mouse enabled, but there's mouseChildren that's not taken into account. I'm thinking I could also add "Only Tab Enabled Objects" by the way because the search logic is somewhat similar to that 👀

But I would prefer to do that in a separate PR anyways as it requires more thinking and testing.

The option "Include Hidden" was not working properly,
as it did not exclude all hidden objects when disabled.
An object is hidden also when its ancestor is not visible.
@Lord-McSweeney Lord-McSweeney merged commit 4e39598 into ruffle-rs:master May 9, 2024
17 checks passed
@kjarosh kjarosh deleted the debug-include-hidden branch May 9, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants