Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video base/stub impls #3117

Merged
merged 30 commits into from
Feb 17, 2021
Merged

Video base/stub impls #3117

merged 30 commits into from
Feb 17, 2021

Conversation

kmeisthax
Copy link
Member

As requested I have extracted all of the non-codec Video support - a fresh display object, associated AVM stubs, and so on. This PR will recognize video tracks in an SWF, store them, and then generate errors as it has no codecs to work with. I've also reorganized the H.263 PR to be downstream of this one. Merging that PR will also merge this one.

I expect the person working on libav VP6 integration (szooloo on Discord but I don't know their Github username) to also make use of this base PR.

As this contains no codecs there should be no patent exposure from merging it.

Copy link

@seanpm2001 seanpm2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, passes all checks, and nothing looks wrong, although it needs further review, as I am not as experienced in Rust as I am in other languages.

@danielhjacobs
Copy link
Contributor

danielhjacobs commented Feb 14, 2021

First, I want to say that I do not know any Rust. Second, I want to say thank you for working on this. I am especially excited for the VP6 branch built off of this one, because that will make many of the videos on the sites I work on work (I tested it on one of them and the results look promising).

I found an issue with this branch versus the official Ruffle release (using a Chrome extension built from this branch versus an official Chrome release). If you go to http://www.insidecancer.org/ with this version of Ruffle, clicking any button on the animation doesn't load anything at all inside the "frame".

The animation works accurately with the official Ruffle release, except of course for the videos, which do not work (easiest video to get to would be clicking "Hallmarks of Cancer", and then number "7"), as well as the scroll bar on certain slides (easiest non-working scroll bar to get to would be "Causes and Prevention", "3", "→", which I suspect would work if TextField.scroll were implemented - #280).

@Herschel Herschel merged commit df5e974 into ruffle-rs:master Feb 17, 2021
@Herschel
Copy link
Member

Thank you!

@vladislavkoz
Copy link

vladislavkoz commented Mar 28, 2022

Hello guys. Is it possible to use video files at all? I'm trying to recover an old game with a lot of FLV files and I'm getting the following error. Could I fix this by converting my FLVs to another supported video format?
image

My FLVs:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants