handling of doc => string data in Bulk Action #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pentarim Thx for the addition. Can you add a small unit test for this one and update the changes.txt file? |
|
@ruflin Added, do you need anything else? |
| @@ -1,5 +1,8 @@ | |||
| CHANGES | |||
|
|
|||
| 2014-03-25 | |||
| - Allow json string as data srouce for Bulk\Action on update | |||
There was a problem hiding this comment.
Please add the pull request id at the end of the line.
|
Only one very small detail (see comment above). Thx. |
ruflin
added a commit
that referenced
this pull request
Mar 25, 2014
handling of doc => string data in Bulk Action
|
Merged. Thx. |
|
Thank you for all your work! |
|
@ruflin can I ask you to tag a release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When JMS Serializer is used with UpdateDocument the source is in the following format:
doc => '{"id":182,"name":"Somename"}'
Added handling of it in \Elastica\Bulk\Action::toString