Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added HHVM to travis.yml #649

Closed
wants to merge 1 commit into from
Closed

Added HHVM to travis.yml #649

wants to merge 1 commit into from

Conversation

Nyholm
Copy link
Contributor

@Nyholm Nyholm commented Jul 9, 2014

No description provided.

@ruflin
Copy link
Owner

ruflin commented Jul 9, 2014

Good idea. Can you update the changes.txt?

@ruflin
Copy link
Owner

ruflin commented Jul 9, 2014

BTW: There seems to be a problem with the hhvm builds:

The `phpize' command exists in these Ruby versions:
  5.2
  5.2.17
  5.3
  5.3.27
  5.3.3
  5.4
  5.4.29
  5.5
  5.5.13
  5.6
  5.6.0beta4

https://travis-ci.org/ruflin/Elastica/jobs/29490619

@Nyholm
Copy link
Contributor Author

Nyholm commented Jul 10, 2014

We don't need to install memcache on HHVM. It is already installed.
I've updated the PR.

@@ -1,5 +1,8 @@
CHANGES

2014-07-09
- Make sure Travis run tests on HHVM.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add the pull request id

@ruflin
Copy link
Owner

ruflin commented Jul 10, 2014

There seem to be problem with one of the Proxy tests:

https://travis-ci.org/ruflin/Elastica/jobs/29506641

@Nyholm
Copy link
Contributor Author

Nyholm commented Jul 10, 2014

Since the tests pass on PHP 5.6 I removed it from the allowed to fail.

The tests are now running on HHVM. This was the intention of this PR. Some tests fail though... I do not know how to fix those. Someone with more knowledge of this lib will make sure they pass.

@ruflin
Copy link
Owner

ruflin commented Jul 10, 2014

As it is only 1 test that fails, I would suggest we add a skip to this test in case it is hhvm.

I had 5.6 still on the "can fail" list as the release is not final. But I agree to move it as the release candidates are out.

@ruflin
Copy link
Owner

ruflin commented Feb 15, 2015

Merged in through #778

@ruflin ruflin closed this Feb 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants