Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk update successfully done, but Elastica\Response->isOk() throws error #698

Closed
fprochazka opened this issue Oct 8, 2014 · 2 comments · Fixed by #702
Closed

Bulk update successfully done, but Elastica\Response->isOk() throws error #698

fprochazka opened this issue Oct 8, 2014 · 2 comments · Fixed by #702

Comments

@fprochazka
Copy link
Contributor

Hi, I'm having problems with bulk updates, has the api been changed, or did I do something wrong?

Request:

snimek obrazovky porizeny 2014-10-08 01 56 26

example document

{"id":708113,"name":"FF Kokosové plátky fólie 100g;","description":"","searchKeywords":"","enable":false,"deleted":true,"menuCode":"236007","ingredients":"","itemEan":"8595081585765","packEan":"8595081585765","categories":["Ovoce"],"inventoryAmount":0,"boughtAmount":0}

Error:

snimek obrazovky porizeny 2014-10-08 01 49 16

this is what the response data looks like

snimek obrazovky porizeny 2014-10-08 01 49 57

Versions:

ElasticSearch:

{
    status: 200
    name: Apollo
    version: {
        number: 1.3.2
        build_hash: dee175dbe2f254f3f26992f5d7591939aaefd12f
        build_timestamp: 2014-08-13T14:29:30Z
        build_snapshot: false
        lucene_version: 4.9
    }
    tagline: You Know, for Search
}

Elastica version

$ composer show --installed
ruflin/elastica                  v1.3.4.0              Elasticsearch Client
@fprochazka
Copy link
Contributor Author

Should I send a pullrequest that will check also $data['errors'] and do an isset around that statement that throws notice?

@ruflin
Copy link
Owner

ruflin commented Oct 8, 2014

That is what I call a good bug report. Thx.

I'm not sure why 'ok' is not set in your item array. Perhaps this go replaced through status in es 1.3.4?

Yes, please open a pull request and we should also have a test to reproduce this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants