Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Response::isOk() to work better with bulk update api #702

Merged
merged 1 commit into from
Oct 13, 2014

Conversation

fprochazka
Copy link
Contributor

[Closes #698]

Is such a testcase okey? Or do you want also a functional test?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.13%) when pulling da1e5b0 on fprochazka:bug/response-isok into c9f41fa on ruflin:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.16%) when pulling cad5ec4 on fprochazka:bug/response-isok into c9f41fa on ruflin:master.

@fprochazka
Copy link
Contributor Author

@ruflin any thoughts? :)

@ruflin
Copy link
Owner

ruflin commented Oct 12, 2014

The tests are ok and quite extensive, I like that 👍 Functional and integration tests are a big plus as it makes sure, it also works with the specific elasticsearch version. This makes it very easy to detect, in case some (return)parameters change. I you can add 1 or 2 integration tests, I'm more then happy.

@fprochazka
Copy link
Contributor Author

@ruflin I would love to write those tests, but I don't know when I'll have the time for it. I think it would be beneficial to merge this (as the tests clearly pass) and I'll try to write some new tests as soon as I can :) On the other hand, if the integration tests are a must, I would give it a bit higher priority so this can be merged earlier. It's up to you :)

ruflin added a commit that referenced this pull request Oct 13, 2014
Fixed Response::isOk() to work better with bulk update api
@ruflin ruflin merged commit 0d2400b into ruflin:master Oct 13, 2014
@ruflin
Copy link
Owner

ruflin commented Oct 13, 2014

I already merged as it doesn't break any of the existing tests. Of course I would still like to make it a higher priority on your side anyways ;-)

Thx for the addition.

@fprochazka
Copy link
Contributor Author

I'll try to write them soon Kdyby/ElasticSearch#2 :) Thank you for the merge!

@ruflin
Copy link
Owner

ruflin commented Oct 13, 2014

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bulk update successfully done, but Elastica\Response->isOk() throws error
3 participants