Adding username and password params to connection #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -38,6 +38,8 @@ class Client | |||
| 'log' => false, | |||
| 'retryOnConflict' => 0, | |||
| 'bigintConversion' => false, | |||
| 'username' => null, | |||
There was a problem hiding this comment.
I was first thinking if we should better add this inside the connections. But that would mean setting it up for each connection. I think it can be expected that all elasticsearch nodes have the same users so I'm happy to have it hear.
|
Yeah, it would probably need either an nginx setup or an elasticsearch node with shield. I'm fine with the current tests as long as you tested it manually? |
|
Ok. Yep, I tested it manually with a server that required credentials as well as one that does not require credentials. |
ruflin
added a commit
that referenced
this pull request
Jan 12, 2016
…entials Adding username and password params to connection
|
Merged. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding username and password params to connection (#949)
I wanted to write functional or at the very least unit tests for Transport\HttpTest.php but I'm unsure the best way to do that. I figured
... a functional test would require a second Elasticsearch instance to test against.
... a unit test isn't possible without pulling the curl_ commands into a wrapper class. I didn't want to blow the scope of this up though.