Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused files in tests #2111

Merged
merged 1 commit into from Aug 12, 2022
Merged

Removed unused files in tests #2111

merged 1 commit into from Aug 12, 2022

Conversation

franmomu
Copy link
Contributor

@franmomu franmomu commented Aug 6, 2022

I was trying to add missing types and bumped into these files that apparently are not used.

CallbackStrategyTestHelper was added in #871 and looks like it has been replaced by a callback:

$callback = static function ($connections) use (&$count): Connection {
++$count;
return \current($connections);
};
$mock = $this->createMock(Connection::class);
$strategy = new CallbackStrategy($callback);
$strategy->getConnection([$mock]);

ErrorsCollector was added in #1031 and its usage was removed in #1742.

Copy link
Owner

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the cleanup.

@ruflin ruflin merged commit 1a2db5f into ruflin:master Aug 12, 2022
@franmomu franmomu deleted the remove_unused branch August 12, 2022 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants