Added ability get defaults index settings #2115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deguif
reviewed
Aug 16, 2022
There was a problem hiding this comment.
@krasilnikovm thanks for this contribution.
Could you add a test to cover this new feature?
|
@deguif I'll add |
krasilnikovm
force-pushed
the
add-ability-fetch-defaults-index-settings
branch
from
e4ee8b1
to
109a2b3
Compare
|
@deguif I added a tests, please take a look |
|
@krasilnikovm Could you add a changelog entry. I did approve the CI run. Thanks for your contribution! |
krasilnikovm
force-pushed
the
add-ability-fetch-defaults-index-settings
branch
2 times, most recently
from
1f71cc4
to
080641e
Compare
deguif
reviewed
Aug 17, 2022
krasilnikovm
force-pushed
the
add-ability-fetch-defaults-index-settings
branch
from
080641e
to
5904f82
Compare
deguif
approved these changes
Aug 17, 2022
ruflin
approved these changes
Aug 18, 2022
| $requestData = $this->request()->getData(); | ||
| $queryParameters = [ | ||
| 'include_defaults' => $includeDefaults, | ||
| ]; |
There was a problem hiding this comment.
Surprised by this codecov comment as I think this part is covered in the tests. Maybe codecov is confused by the ] 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.