New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[site/theme,#88]: Custom links component with support for video embeds in MDX #95
Conversation
✅ Deploy Preview for boring-fermat-22cb64 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@khalilcodes this looks like it has conflicts. Are you able to resolve and then we merge? |
@rufuspollock yes, will update the code. |
@khalilcodes is this ready to merge? Also can you point to an example page using it in the preview deploy ... |
@rufuspollock I will replace the iframe with the youtube link in one of the 'notes/...' page and commit so it can be previwed. |
@rufuspollock a working preview can be seen here - https://deploy-preview-95--boring-fermat-22cb64.netlify.app/notes/are-crypto-tokens-securities ... looks like it's ready to be merged. |
@rufuspollock @sdiehl Right now if we merge this the links are broken again as seen in preview. |
I reverted the last commit that flattened the subdirectory. |
@khalilcodes can you summarize where we are at - i also note this PR has got a bit messy including both fixes to titles (?) and youtube change etc. Can you put in a PR just for the titles fix. Then do a PR just for youtube stuff. Aside: i think we create a "test.md" where we can put whatever we want to test and not mess with the other pages. |
Closing this PR and resubmitting a new one with youtube stuff only. |
Video URL links such as https://www.youtube.com/watch?v=z2uAg-AIs-Y (Youtube, etc) surrounded by newlines in markdown will embed an iframe on the page.
*Similar concept from: https://github.com/agentofuser/remark-oembed
Additional support for links added (since a custom link component is being created):
Notes: moving to contentlayer, md pages now support raw html making the iframe display on page #88 (comment)