Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL: overlap in bottom panel/skin selector #63

Closed
rugk opened this issue Oct 19, 2019 · 1 comment · Fixed by #101
Closed

RTL: overlap in bottom panel/skin selector #63

rugk opened this issue Oct 19, 2019 · 1 comment · Fixed by #101
Labels
bug Something isn't working i18n/l10n internationalisation & localisation UI/usability/UX

Comments

@rugk
Copy link
Owner

rugk commented Oct 19, 2019

Bug description

As reported by @shanirub in #62 (comment):

The small circle that represents the skin tone overlaps the text "Awesome Emoji" [in a RTL language].

Steps to reproduce

  1. (Use a version with the Hebrew or another RTL language translation.)
  2. Choose that language in the settings of Firefox.
  3. Restart Firefox.
  4. Open emoji picker.

Actual behavior

awesome-emoji-picker-display-bug

emoji

Expected behavior

  • emoji should be at the right
  • skin selector should be on the left

System

Operating system and version: Fedora 30
Browser and version: Firefox 69
Add-on version: dev (master)

Possible solution

likely CSS

Related issue: #64

@rugk rugk added bug Something isn't working UI/usability/UX i18n/l10n internationalisation & localisation labels Oct 19, 2019
@rugk
Copy link
Owner Author

rugk commented Oct 19, 2019

I've tried to reproduce this on the website of the used lib, i.e. https://missive.github.io/emoji-mart/, but it does work better there, strangely… 🤔

grafik

The text is left aligned (although the there has problems), but at least it does not overlap the emoji picker there, so…

So, anyway, I've reported this upstream at missive/emoji-mart#370.
I am not yet 100% sure, whether the actual overlapping is caused, because of the RTL text actually being used in there, or because of a change in this add-on. (particularly this CSS thing could be a problem).


In any case, as in #64, I am marking this as "help wanted", because if anyone has experience with RTL/LTR text and issues like, we could take some suggestions/need solutions (or even PRs 😉) here…
Some workarounds for now would also be fine, but I don't know what is the best and reasonable way now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working i18n/l10n internationalisation & localisation UI/usability/UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant