Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hebrew translation #62

Merged
merged 1 commit into from
Oct 19, 2019
Merged

Hebrew translation #62

merged 1 commit into from
Oct 19, 2019

Conversation

shanirub
Copy link
Contributor

As I tested my translation I've noticed two bugs:

  1. The small circle that represents the skin tone overlaps the text "Awesome Emoji".
    awesome-emoji-picker-display-bug
  2. Under the behaviour settings the "colon code / unicode" option is incorrectly displayed.
    awesome-emoji-picker-colon-bug

@rugk
Copy link
Owner

rugk commented Oct 19, 2019

Hi @shanirub,
thanks for your first contribution to this project (too)! 🎉 👍 🏅
I hope you'll like this project and enjoy hacking on it… 😃

Please subscribe to #27 to get notified for new updates on translations etc. 😃

Also notice there are more things to translate like the add-on listings on AMO (addons.mozilla.org) etc. See the contributing guide for more information.

As for the bugs: Thanks for testing. I'll take a look and open issues for them.

@rugk
Copy link
Owner

rugk commented Oct 19, 2019

Okay, bugs reported and partially forwarded to upstream in #64, #63 (and thus missive/emoji-mart#370).

So ignoring these issues, which need more things to do, this LGTM, so merging… 😃

@rugk rugk merged commit 36e327e into rugk:master Oct 19, 2019
@rugk rugk added this to the 1.2 milestone Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants