Added Thunderbird support #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdulcet
commented
Jun 2, 2022
rugk
requested changes
Jun 4, 2022
| thunderbird: "https://addons.thunderbird.net/thunderbird/addon/unicodify-text-transformer/?utm_source=unicodify-addon&utm_medium=addon&utm_content=unicodify-addon-settings-inline&utm_campaign=unicodify-addon-settings-inline", | ||
| chrome: "https://chrome.google.com/webstore/detail/unicodify-text-transformer/", | ||
| }).then((browserUrl) => { | ||
| document.getElementById("link-unicodify").href = browserUrl; |
There was a problem hiding this comment.
Hmm I don't see that ID being used anywhere in the options.html?
There was a problem hiding this comment.
Oops, this ID would be used by #93, so I will comment this line out and add a comment. Alternatively, I could add something like this to options.html:
<span class="helper-text">For Unicode font conversion from the context menu, please try our <strong>υ</strong> <a id="link-unicodify">Unicodify</a> add-on.</span>
Co-authored-by: rugk <rugk+git@posteo.de>
rugk
approved these changes
Jun 5, 2022
Yes, I will create another PR after this is merged with the rest of the changes from the published ATN version of the add-on (see #49 (comment)). |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added initial Thunderbird support. Fixes #49
Requires renaming the
thunderbirdmanifest.jsonfile tomanifest.jsonand moving it tosrc/.More changes will be needed if/when #93 is merged.