Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the French translation #76

Merged
merged 11 commits into from
Jan 26, 2020
Merged

Update the French translation #76

merged 11 commits into from
Jan 26, 2020

Conversation

Prometheos2
Copy link
Contributor

@Prometheos2 Prometheos2 commented Jan 17, 2020 •
edited

It seems I'm extremely late, so sorry about that 馃槬

I will increment it and remove the WIP status once the whole is ready for reviews.

@Prometheos2
Update the French amoSummary.txt.
c0c352e 
From:
[47421ab] "Update add-on & AMO descriptions/Readme texts"
(09/05/19)
@Prometheos2
Copy link
Contributor Author

@rugk, would you like me to trim the tables' space in the permission description file?

@Prometheos2 Prometheos2 requested a review from rugk January 17, 2020 13:48
@Prometheos2
Copy link
Contributor Author

I will take a look at changelogs a bit later.

@Prometheos2 Prometheos2 marked this pull request as ready for review January 17, 2020 13:58
@rugk
Copy link
Owner

rugk commented Jan 20, 2020

@rugk, would you like me to trim the tables' space in the permission description file?

Yeah, well. Actually, do make whatever helps/fits you best when you maybe need to update the text later.

rugk
rugk reviewed Jan 20, 2020
View reviewed changes
Copy link
Owner

@rugk rugk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting a potential review from @nicolas-trouin. Unless there are objections, this will be merged soon.

@rugk
Copy link
Owner

rugk commented Jan 20, 2020

It seems I'm extremely late, so sorry about that 馃槬

No problem, AMO changes can always be added and the other things just go into the next release. 馃槂

@R3ddingt0n
Copy link

Hello, I'll check this out tonight or tomorrow 馃槄

R3ddingt0n
R3ddingt0n suggested changes Jan 22, 2020
View reviewed changes
Copy link

@R3ddingt0n R3ddingt0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's what I found :

  • Some typos
  • Some phrases are unclear
  • Some vocabulary is not perfect, according to my opinion

assets/texts/fr/amoDescription.html Outdated Show resolved Hide resolved
assets/texts/fr/amoScreenshots.csv Outdated Show resolved Hide resolved
assets/texts/fr/amoDescription.html Outdated Show resolved Hide resolved
assets/texts/fr/amoDescription.html Show resolved Hide resolved
assets/texts/fr/amoScreenshots.csv Outdated Show resolved Hide resolved
assets/texts/fr/amoScreenshots.csv Outdated Show resolved Hide resolved
assets/texts/fr/permissions.md Outdated Show resolved Hide resolved
R3ddingt0n
R3ddingt0n approved these changes Jan 24, 2020
View reviewed changes
Copy link

@R3ddingt0n R3ddingt0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd only suggest to change the r茅pandant l'information by something else (see my previous comment).

Everything else seems fine :)

@Prometheos2
Copy link
Contributor Author

Prometheos2 commented Jan 25, 2020 •
edited

That should be good then.

@rugk, would you like me to rewrite the commit history into something "cleaner"?

@rugk
Copy link
Owner

rugk commented Jan 26, 2020

No, commit history is fine. I could always rewrite it when merging.

Thanks for that collaboration & reviewing BTW. 馃槂
That's how it's supposed to work.

Merging now.

@rugk rugk merged commit 8ab262c into rugk:master Jan 26, 2020
@Prometheos2 Prometheos2 deleted the lang/fr-fr branch January 27, 2020 02:07
@rugk rugk added this to the 2.0 milestone Mar 20, 2020
@rugk rugk added the i18n/l10n internationalisation & localisation label Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rugk rugk rugk approved these changes

@R3ddingt0n R3ddingt0n R3ddingt0n approved these changes

Assignees
No one assigned
Labels
i18n/l10n internationalisation & localisation
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Prometheos2 @rugk @R3ddingt0n