Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remember last size does work as expected #102

Closed
TauseefMalik opened this issue Jun 18, 2018 · 6 comments
Closed

Remember last size does work as expected #102

TauseefMalik opened this issue Jun 18, 2018 · 6 comments
Labels
bug Something isn't working
Milestone
1.2.1

Comments

@TauseefMalik
Copy link

I changed the QR code size option to 'remember the last size' but it could not restore to the previous size on next launch.
Windows 10
Firefox 60.0.2
@rugk rugk added the bug Something isn't working label Jun 18, 2018
@extern-c
Copy link
Contributor

May I help with this?

@rugk
Copy link
Owner

rugk commented Jun 19, 2018

If you can, sure. Totally have a look.
I had to look at the feature several times, it is still quite fragile. Or maybe this is a regression in the v1.2?

BTW for debugging best use the debugger. Just in case you did not know about this.☺

@extern-c
Copy link
Contributor

Thanks for letting me know about the debugger. I will keep you updated.

@extern-c
Copy link
Contributor

Done. I have made a pull request. Please let me know if the solution was satisfactory. I would like to actively contribute to this project.

@rugk rugk added this to the 1.2.1 milestone Jun 20, 2018
@rugk
Copy link
Owner

rugk commented Jun 20, 2018

BTW I think when this is fixed, I'll release it as a hotfix, because it is an annoying bug and it should not stay unfixed until v1.3.

@extern-c extern-c mentioned this issue Jun 21, 2018
Merged
@rugk rugk closed this as completed in 44fbac7 Jun 22, 2018
@rugk rugk reopened this Jun 22, 2018
@rugk rugk mentioned this issue Jun 22, 2018
Closed
extern-c added a commit to extern-c/offline-qr-code that referenced this issue Jun 23, 2018
@extern-c
Fixed rugk#102 by adding variable initialClick.
216dc71
@extern-c extern-c mentioned this issue Jun 23, 2018
Closed
@rugk rugk closed this as completed in 353192e Jul 1, 2018
@rugk
Copy link
Owner

rugk commented Jul 1, 2018

Release with hotfix is published and live!

daaAd1 pushed a commit to daaAd1/offline-qr-code that referenced this issue Sep 30, 2019
@rugk
Observe size changes later to fix rugk#102
64e866d 
Thanks to previous debugging work by @AmauriAires.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.2.1
Development

No branches or pull requests
3 participants
@extern-c @rugk @TauseefMalik